samples: subsys: ipc: basic: Basic cores communication #4
Conversation
Add basic cores communication sample to show how to send messages between two cores using mbox and shared data structure. Signed-off-by: Jakub Zymelka <jakub.zymelka@nordicsemi.no>
There was a problem hiding this comment.
I left a few nitpicking notes. I am also wondering: is it possible that one of the first mbox messages ("No data from host/remote") is missed because the other core enabled mbox after some delay? Or maybe mbox does not send anything until it is enabled by both cores?
Besides that, LGTM.
| Overview | ||
| ******** | ||
|
|
||
| This application demonstrates how to communcate between cores without any backend in |
There was a problem hiding this comment.
| This application demonstrates how to communcate between cores without any backend in | |
| This application demonstrates how to communicate between cores without any backend in |
|
|
||
| *** Booting Zephyr OS build v3.7.0-rc1-427-g7f891a6a40e8 *** | ||
| I: No data from remote | ||
| I: Sent 14 bytes to host |
There was a problem hiding this comment.
| I: Sent 14 bytes to host | |
| I: Sent 14 bytes to remote |
I guess it should be remote, as it is the host's log.
| ordered: false | ||
| regex: | ||
| - "No data from remote" | ||
| - "Sent 14 bytes to host" |
There was a problem hiding this comment.
| - "Sent 14 bytes to host" | |
| - "Sent 14 bytes to remote" |
| data_packet_t data_packet; | ||
|
|
||
| /** | ||
| * @brief Send data to aother core |
There was a problem hiding this comment.
| * @brief Send data to aother core | |
| * @brief Send data to another core |
| int bytes_sent = 0; | ||
|
|
||
| int ret = mbox_init(); |
There was a problem hiding this comment.
| int bytes_sent = 0; | |
| int ret = mbox_init(); | |
| int bytes_sent = 0; | |
| int ret = mbox_init(); | |
To fix compliance check
|
|
||
| /** | ||
| * @brief Verify whether another core has data ready for us to read | ||
| * @return -1 if lock is not acquired, otherwise how many items are available for reading |
There was a problem hiding this comment.
I would put it the other way around:
"Number of items available for reading, -1 if lock is not acquired"
| * @brief Send data to aother core | ||
| * @param buffer | ||
| * @param size | ||
| * @return -1 if lock is not acquired, otherwise how many items were transfered |
There was a problem hiding this comment.
Same as in the host main.c
| return -1; | ||
| } | ||
|
|
||
| /* Limit size of buffer to be transfered to the size of destine buffer */ |
There was a problem hiding this comment.
I guess it should be "destination buffer" or "destined buffer".
| * @brief Get data from another core | ||
| * @param buffer | ||
| * @param size | ||
| * @return -1 if lock is not acquired, otherwise how many items were read |
There was a problem hiding this comment.
Same as in the host main.c
|
Changes moved to nrfconnect/sdk-zephyr#1910 . |
Add basic cores communication sample to show how to send messages between two cores using mbox and shared data structure.