common: Fix compilation warnings replace deprecated functions gtk_rc_get_theme_dir and gtk_rc_scanner_new

[zhuyaliang]

No description provided.

[lukefromdc]

Builds and runs fine, themes are properly rendered in mate-appearance-properties, which I am presuming to be the main user of the theme tester. Current GTK theme properly applied to the control center itself.

We get these four runtime warnings from mate-appearance-properties (with the newer glib versions only) but they are shared with master, need to be fixed elsewhere in the code, and that can be a separate PR. Opened issue #735 for it:

(mate-appearance-properties:34711): GLib-GIO-CRITICAL **: 15:12:11.817: GFileInfo created without standard::type

(mate-appearance-properties:34711): GLib-GIO-CRITICAL **: 15:12:11.817: file ../gio/gfileinfo.c: line 1611 (g_file_info_get_file_type): should not be reached

(mate-appearance-properties:34711): GLib-GIO-CRITICAL **: 15:12:11.817: GFileInfo created without standard::type

(mate-appearance-properties:34711): GLib-GIO-CRITICAL **: 15:12:11.817: file ../gio/gfileinfo.c: line 1611 (g_file_info_get_file_type): should not be reached
No such key “theme”

[raveit65]

gtkrc is for gtk-2.0 themes. See https://github.com/mate-desktop/mate-themes/tree/master/desktop-themes/BlueMenta/gtk-2.0 for example. So do we need this code with gtk-3.0 themes?

[zhuyaliang]

gtkrc is for gtk-2.0 themes. See https://github.com/mate-desktop/mate-themes/tree/master/desktop-themes/BlueMenta/gtk-2.0 for example. So do we need this code with gtk-3.0 themes?

I know little about the theme, and I don't know how to add gtk3 support

[raveit65]

Opps, i did a force push by accidental but i was able to restore previous state.
I hope code is now OK.

[raveit65]

gtkrc is for gtk-2.0 themes. See https://github.com/mate-desktop/mate-themes/tree/master/desktop-themes/BlueMenta/gtk-2.0 for example. So do we need this code with gtk-3.0 themes?

I know little about the theme, and I don't know how to add gtk3 support

Correct me if i am wrong. gtk_rc_get_theme_dir is used to find the directory where themes are installed and gtk_rc_scanner_new scans the gtk_color value in the theme_dir/gtk-2.0/gtkrc file.
I am thinking minimum gtk_rc_scanner_new is obsolete because i can remove the `theme_dir/gtk-2.0/ folder from our themes and m-a-p find the theme with colors.
Also, nowadays gtk-2.0 isn't use by any application any more, ihmo. I am thinking about to remove gtk-2.0 part from our themes because the gtk-murrine-engine which is used by gtk-2.0 themes will be removed from fedora soon.
Any way, i will test for myself if both functions are really used nowadays.

[raveit65]

LGTM,
m-a-p runs like before and deprecated warnings are gone.