Fix test for first entry serialization #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/fix-tests
branch
from
b2d2d5b
to
8b6c9d8
Compare
ml-evs
force-pushed
the
ml-evs/fix-tests
branch
from
8b6c9d8
to
fc0cf45
Compare
ml-evs
commented
Mar 31, 2024
eimrek
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not properly testing attributes generated here; test values may need updating as a result. This found a bug in property detection in cases where two individual property files use different ID schemes (see #55 too). The converter was updated to properly handle this case, and the test comparisons were made stricter.