Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting proofs and reshuffling code #1041

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CohenCyril
Copy link
Member

@CohenCyril CohenCyril commented Oct 3, 2023

Motivation for this change

This PR slightly refactor the proof of topolology for \bar R, for R : realFieldType and exhibitting the wrong behaviour for R : numFieldType.

@affeldt-aist
This PR also provide the proof in #1040 but without the dependency in C... (thus assuming the existence of i st `|i| = 1 and i \isn't Num.real).

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@CohenCyril CohenCyril marked this pull request as draft October 3, 2023 14:34
@affeldt-aist
Copy link
Member

Thanks. This also makes (minor) generalizations clearer.
While playing around with the topological definitions, I also observed the following one: issue #1042
now PRed in PR #1043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants