Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container logs not flushed if there is a timeout spinning up a container #484

Open
richvdh opened this issue Sep 29, 2022 · 1 comment
Open

Comments

@richvdh
Copy link
Member

richvdh commented Sep 29, 2022

#392 added a ContainerStop to Deployer.Destroy, so that the container has a chance to gracefully shut down and flush its logs before we print them.

However, we print the logs in a couple of other situations:

  • in Deployer.Deploy, if there is a timeout waiting for the container to be ready. (In this case it looks like we don't destroy the container at all?)
  • in Builder.ConstructBlueprint (via Builder.construct).

In both these cases, the logs are printed before the container is stopped.

@richvdh
Copy link
Member Author

richvdh commented Sep 29, 2022

I don't really understand why we have three different code paths for this, but in any case, it looks like moving the call to ContainerStop into printLogs will solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant