Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully shut down container when we want logs #392

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Gracefully shut down container when we want logs #392

merged 2 commits into from
Jun 10, 2022

Conversation

erikjohnston
Copy link
Member

This gives the container a chance to flush out any pending logs, otherwise we can end up with truncated logs.

@erikjohnston
Gracefully shut down container when we want logs
85dcac8 
This gives the container a chance to flush out any pending logs,
otherwise we can end up with truncated logs.
@erikjohnston erikjohnston requested review from kegsay and a team June 10, 2022 10:02
squahtx
squahtx approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 suggestion, otherwise looks good to me!

I wonder if homeservers might sometimes take more than a second to shut down. Synapse certainly does for production instances.

internal/docker/deployer.go Outdated Show resolved Hide resolved
@erikjohnston
Copy link
Member Author

1 suggestion, otherwise looks good to me!

I wonder if homeservers might sometimes take more than a second to shut down. Synapse certainly does for production instances.

Yeah, though I really only care about keeping them going long enough to flush the logs from the tests.

@erikjohnston erikjohnston merged commit 2503a6d into main Jun 10, 2022
@erikjohnston erikjohnston deleted the erikj/fix_logs branch June 10, 2022 11:45
@MadLittleMods MadLittleMods mentioned this pull request Jul 7, 2022
Open
@richvdh richvdh mentioned this pull request Sep 29, 2022
Open
@matrixbot matrixbot mentioned this pull request Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squahtx squahtx squahtx approved these changes

@kegsay kegsay Awaiting requested review from kegsay kegsay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @squahtx