Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestMediaFilenames incorrectly tests Content-Disposition #645

Closed
Half-Shot opened this issue Aug 8, 2023 · 1 comment · Fixed by #646
Closed

TestMediaFilenames incorrectly tests Content-Disposition #645

Half-Shot opened this issue Aug 8, 2023 · 1 comment · Fixed by #646

Comments

@Half-Shot
Copy link
Collaborator

Content-Disposition is not a spec defined behaviour (it's not mentioned in https://spec.matrix.org/v1.7/client-server-api/ other than for the filename, and complement should not be prescribing that servers act a certain way without a spec to cover it.

It's up to homeservers to decide what media types may be presented inline or as attachments (and something we're trying to fix in matrix-org/synapse#15988 to fix a unsatisfactory situation).

@Half-Shot
Copy link
Collaborator Author

This appears to have originally come from sytest, which also is testing this behaviour wrongly. #639.

Ultimately I'd be in favour of at most checking Content-Disposition is a valid value, but realistically we can't expect developers to pass these tests until the spec defines the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant