-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More test coverage to ensure we process MSC2716 events in existing room versions #209
Merged
MadLittleMods
merged 3 commits into
master
from
madlittlemods/synapse-10962-more-robust-existing-room-version-test-msc2716
Oct 26, 2021
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -782,6 +782,9 @@ func TestImportHistoricalMessages(t *testing.T) { | |
eventIdBefore := eventIDsBefore[0] | ||
timeAfterEventBefore := time.Now() | ||
|
||
// Create eventIDsAfter to avoid the "No forward extremities left!" 500 error from Synapse | ||
createMessagesInRoom(t, alice, roomID, 2) | ||
|
||
// Import a historical event | ||
batchSendRes := batchSendHistoricalMessages( | ||
t, | ||
|
@@ -796,6 +799,7 @@ func TestImportHistoricalMessages(t *testing.T) { | |
) | ||
batchSendResBody := client.ParseJSON(t, batchSendRes) | ||
historicalEventIDs := client.GetJSONFieldStringArray(t, batchSendResBody, "event_ids") | ||
nextBatchID := client.GetJSONFieldStr(t, batchSendResBody, "next_batch_id") | ||
|
||
messagesRes := alice.MustDoFunc(t, "GET", []string{"_matrix", "client", "r0", "rooms", roomID, "messages"}, client.WithContentType("application/json"), client.WithQueries(url.Values{ | ||
"dir": []string{"b"}, | ||
|
@@ -809,6 +813,20 @@ func TestImportHistoricalMessages(t *testing.T) { | |
}, nil), | ||
}, | ||
}) | ||
|
||
// Now try to do a subsequent batch send. This will make sure | ||
// that insertion events are stored/tracked and can be matched up in the next batch | ||
batchSendHistoricalMessages( | ||
t, | ||
as, | ||
roomID, | ||
eventIdBefore, | ||
nextBatchID, | ||
createJoinStateEventsForBatchSendRequest([]string{virtualUserID}, timeAfterEventBefore), | ||
createMessageEventsForBatchSendRequest([]string{virtualUserID}, timeAfterEventBefore, 1), | ||
// Status | ||
200, | ||
) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It was a logic error only with existing room versions in Synapse. |
||
}) | ||
|
||
t.Run("Not allowed to redact MSC2716 insertion, batch, marker events", func(t *testing.T) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poor comment wording. You reference
eventIDsAfter
like it's a variable but it isn't used here?Do you really mean:
?
What does this have to do with room versions anyway? This just seems to be a logic error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I mean, but the goal is to match the
eventIDsAfter
we use in other tests in this same place. The only reason I can't leave it there is because Go complains about it being unused.