Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /send_leave handling to GMSL #3088

Closed
wants to merge 14 commits into from
Closed

Move /send_leave handling to GMSL #3088

wants to merge 14 commits into from

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented May 26, 2023

@S7evinK S7evinK added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label May 26, 2023
@S7evinK S7evinK requested a review from a team as a code owner May 26, 2023 08:24
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (b8f9148) 65.20% compared to head (86ad6c6) 65.18%.

Files Patch % Lines
federationapi/routing/leave.go 8.82% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
- Coverage   65.20%   65.18%   -0.03%     
==========================================
  Files         507      507              
  Lines       57285    57202      -83     
==========================================
- Hits        37353    37287      -66     
+ Misses      16030    16026       -4     
+ Partials     3902     3889      -13     
Flag Coverage Δ
unittests 49.74% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK closed this Aug 3, 2024
@S7evinK
Copy link
Contributor Author

S7evinK commented Aug 3, 2024

Not needed anymore, iirc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants