Fix matrix metrics handling (#869)

* Fix matrix metrics handling * Add changelog Co-authored-by: Tadeusz Sośnierz <tadeusz@sosnierz.com>
matrix-org · Nov 10, 2022 · 64eea45 · 64eea45
1 parent d582bc3
commit 64eea45
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/changelog.d/869.bugfix b/changelog.d/869.bugfix
@@ -0,0 +1 @@
+Fix a crash caused by processing metrics for Matrix events.
diff --git a/src/metrics.ts b/src/metrics.ts
@@ -69,7 +69,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics {
     private remoteRequest: Histogram<string>;
     private matrixRequest: Histogram<string>;
     private requestsInFlight: Map<string, number>;
-    private matrixRequestStatus: Map<string, "success"|"failed">;
+    private matrixRequestStatus: Map<string, "success"|"failed"> = new Map();
     private httpServer: http.Server;
     private remoteMonthlyActiveUsers: Gauge<string>;
     private bridgeBlocked: Gauge<string>;
@@ -116,7 +116,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics {
 
         this.matrixRequest = new Histogram({
             help: "Histogram of processing durations of received Matrix messages",
-            labelNames: ["outcome"],
+            labelNames: ["outcome", "method"],
             name: "matrix_request_seconds",
         });
         register.registerMetric(this.matrixRequest);
@@ -208,7 +208,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics {
         this.matrixRequestStatus.delete(context.uniqueId);
         this.matrixRequest.observe({
             method: context.functionName,
-            result: successFail,
+            outcome: successFail,
         }, timeMs);
     }