Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails with latest Typescript #487

Closed
pacien opened this issue Jun 5, 2019 · 1 comment
Closed

Compilation fails with latest Typescript #487

pacien opened this issue Jun 5, 2019 · 1 comment

Comments

@pacien
Copy link
Contributor

pacien commented Jun 5, 2019

The compilation of matrix-appservice-discord fails with the latest version of the Typescript compiler (3.5.1).

The issue is partly due to an outdated dependency that needs to be updated: sindresorhus/p-queue#66.

src/bot.ts and src/store.ts also need to be adapted.

Compilation log:

> matrix-appservice-discord@0.5.0 build /nix/store/5xwznxq75pba6p0id9ip5qy0aixjzqdl-node_matrix-appservice-discord-0.5.0/lib/node_modules/matrix-appservice-discord
> tsc

node_modules/p-queue/index.d.ts(81,54): error TS2344: Type 'DefaultAddOptions' does not satisfy the constraint 'QueueAddOptions'.
  Index signature is missing in type 'DefaultAddOptions'.
src/bot.ts(156,50): error TS2345: Argument of type 'Promise<unknown>' is not assignable to parameter of type 'Promise<{}>'.
  Type 'unknown' is not assignable to type '{}'.
src/store.ts(69,9): error TS2322: Type 'unknown' is not assignable to type 'void | {}'.
  Type 'unknown' is not assignable to type '{}'.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! matrix-appservice-discord@0.5.0 build: `tsc`
npm ERR! Exit status 2
pacien added a commit to pacien/matrix-appservice-discord that referenced this issue Jun 6, 2019
github: closes matrix-org#487

Signed-off-by: pacien <pacien.trangirard@pacien.net>
pacien added a commit to pacien/matrix-appservice-discord that referenced this issue Jun 7, 2019
fixing compilation with Typescript 3.5.1

github: closes matrix-org#487

Signed-off-by: pacien <pacien.trangirard@pacien.net>
@pacien
Copy link
Contributor Author

pacien commented Jun 7, 2019

Fixed by #489.

@pacien pacien closed this as completed Jun 7, 2019
Half-Shot pushed a commit that referenced this issue Jun 13, 2019
github: closes #487

Signed-off-by: pacien <pacien.trangirard@pacien.net>
Half-Shot pushed a commit that referenced this issue Jun 13, 2019
fixing compilation with Typescript 3.5.1

github: closes #487

Signed-off-by: pacien <pacien.trangirard@pacien.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant