Return promises inside Promise.all map

[f0x52]

Currently this code doesn't return anything inside the map() callback, resulting in an array with undefined elements, and Promise.all() immediately returning.

matrix-appservice-irc/src/bridge/MatrixHandler.ts

Lines 766 to 768 in b0fb738

	await Promise.all(Object.keys(members).map((u) => {
	this.membershipQueue.leave(event.room_id, u, req);
	}));

Fixed it by adding a return but could also be styled as

await Promise.all(Object.keys(members).map((u) => this.membershipQueue.leave(event.room_id, u, req)));`

Caught this when I added my standard eslint config to my fork, might be useful to include the array-callback-return rule here too.

[f0x52]

The eslint rule also catches this line, though there it doesn't really matter as the return value isn't used anyways (but forEach would be more semantically correct)

matrix-appservice-irc/src/bridge/RoomAccessSyncer.ts

Lines 459 to 461 in b0fb738

	matrixRooms.map((room) => {
	this.ircBridge.getStore().setModeForRoom(room.getId(), "s", enabled);
	});

[Half-Shot]

This is fine, but needs a signoff before I can merge it.

[f0x52]

Signed-off-by: f0x github@cthu.lu

[tadzik]

I think this is okay to merge, even without the changelog (it's a very internal change afaic).