Ignore .gitkeep files in towncrier checks #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhsjdhjs
reviewed
Aug 1, 2024
changelog.d/1812.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Fix towncrier failing for wrong reasons. | |||
There was a problem hiding this comment.
The filename doesn't match the PR id, it should be 1813.
|
This also affects the tests in #1809 |
thomwiggers
approved these changes
Aug 14, 2024
Half-Shot
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue in #1812 (#1812 (comment))