Support pagination in the Space Summary API #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatrixSDK/Space/MXSpaceService.swift
Outdated
| /// - completion: A closure called when the operation completes. | ||
| /// - Returns: a `MXHTTPOperation` instance. | ||
| @discardableResult | ||
| public func getSpaceChildrenForSpace(withId spaceId: String, | ||
| suggestedOnly: Bool, | ||
| limit: Int?, | ||
| maxDepth: Int?, | ||
| from: String?, |
There was a problem hiding this comment.
I think we can use something like from pagintationToken: String? to be more explicit
MatrixSDK/Space/MXSpaceService.swift
Outdated
Comment on lines
277
to
293
| // var spaceSummary: MXRoomSummary? | ||
| // | ||
| // if from == nil { | ||
| // guard let rootSpaceChildSummaryResponse = rooms.first(where: { spaceResponse -> Bool in | ||
| // return spaceResponse.roomId == spaceId | ||
| // }) else { | ||
| // // Fail to find root child. We should have at least one room for the requested space | ||
| // self.completionQueue.async { | ||
| // completion(.failure(MXSpaceServiceError.spaceNotFound)) | ||
| // } | ||
| // return | ||
| // } | ||
| // | ||
| // // Build the queried space summary | ||
| // spaceSummary = self.createRoomSummary(with: rootSpaceChildSummaryResponse) | ||
| // } | ||
| // |
There was a problem hiding this comment.
Is it temporary or the commented code can be removed?
- Update after review
- Update after merge with develop
SBiOSoftWhare
approved these changes
Oct 27, 2021
gileluard
deleted the
gil/4893_support_pagination_in_the_space_summary_api
branch
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for element-hq/element-ios#4893