Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Make integration tests work again on CI #1535

Closed
wants to merge 24 commits into from

Conversation

manuroe
Copy link
Contributor

@manuroe manuroe commented Jul 25, 2022

I created a new test plan called AllWorkingTests where 345 out of of 805 tests are disabled because:

  • their test class contains one test that crashes
  • they fail (22 of them)

It gives a test coverage of 49.6%.

to match the version in Podfile.lock
There are useful to keep the counter of remaining sessions after the test
The method is optional in the protocol but some swift code requires it. Stub it to make swift code work.
They pass now. They crashed in remaining opened sessions probably because of other integration tests
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #1535 (2ed4d09) into develop (f6f1f15) will increase coverage by 39.29%.
The diff coverage is 77.27%.

@@             Coverage Diff              @@
##           develop    #1535       +/-   ##
============================================
+ Coverage    12.05%   51.35%   +39.29%     
============================================
  Files          512      514        +2     
  Lines        83831    83775       -56     
  Branches     35790    37344     +1554     
============================================
+ Hits         10103    43019    +32916     
+ Misses       73360    39656    -33704     
- Partials       368     1100      +732     
Impacted Files Coverage Δ
MatrixSDK/Data/Store/MXMemoryStore/MXMemoryStore.m 65.80% <0.00%> (+44.06%) ⬆️
MatrixSDKTests/MXAsyncTaskQueueUnitTests.swift 100.00% <ø> (ø)
...rixSDKTests/MXAuthenticationSessionUnitTests.swift 81.31% <ø> (-1.16%) ⬇️
MatrixSDKTests/MXCryptoRecoveryServiceTests.m 0.00% <0.00%> (ø)
MatrixSDKTests/MXEventAnnotationUnitTests.swift 96.29% <ø> (-0.26%) ⬇️
MatrixSDKTests/MXEventReferenceUnitTests.swift 96.22% <ø> (-0.27%) ⬇️
MatrixSDKTests/MXHTTPClientTests.m 65.78% <ø> (+65.78%) ⬆️
MatrixSDKTests/MXLazyLoadingTests.m 0.00% <0.00%> (ø)
MatrixSDKTests/MXLocationServiceTests.swift 0.00% <0.00%> (ø)
MatrixSDKTests/MXMegolmExportEncryptionUnitTests.m 100.00% <ø> (ø)
... and 310 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f1f15...2ed4d09. Read the comment docs.

@manuroe manuroe force-pushed the manu/working_test_plans_2 branch 2 times, most recently from 4ef1d92 to 1042ce6 Compare July 25, 2022 22:23
even if we cannot get the code coverage
It weirdly works. It rebuilds the whole project which takes time. Then it does not retry all the failed test. It can even run 0 tests on the retry, which makes the CI succeeds for non good reasons
@manuroe manuroe force-pushed the manu/working_test_plans_2 branch 5 times, most recently from d84124f to c2a0434 Compare July 27, 2022 11:23
@manuroe
Copy link
Contributor Author

manuroe commented Aug 1, 2022

Superseded by #1537.

@manuroe manuroe closed this Aug 1, 2022
@manuroe manuroe deleted the manu/working_test_plans_2 branch August 1, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants