Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send an empty dictionary when calling /join to be spec compliant. #1539

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 1, 2022

The SDK isn't sending spec-complaint joins, and Synapse is about to stop handling these: matrix-org/synapse#13388.

Fixes element-hq/element-ios#6481.

@pixlwave pixlwave requested review from a team and ismailgulek and removed request for a team August 1, 2022 15:29
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #1539 (fb326d8) into develop (93670ea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1539   +/-   ##
========================================
  Coverage    51.19%   51.20%           
========================================
  Files          514      514           
  Lines        83952    83956    +4     
  Branches     37409    37416    +7     
========================================
+ Hits         42983    42989    +6     
+ Misses       39866    39865    -1     
+ Partials      1103     1102    -1     
Impacted Files Coverage Δ
MatrixSDK/MXRestClient.m 45.65% <100.00%> (-0.02%) ⬇️
...Crypto/CrossSigning/JSONModels/MXCrossSigningKey.m 92.39% <0.00%> (-1.09%) ⬇️
MatrixSDK/Data/Store/MXMemoryStore/MXMemoryStore.m 65.80% <0.00%> (-0.87%) ⬇️
MatrixSDK/Utils/MXHTTPClient.m 51.10% <0.00%> (-0.51%) ⬇️
...Data/Store/MXRealmCryptoStore/MXRealmCryptoStore.m 72.21% <0.00%> (-0.15%) ⬇️
MatrixSDK/MXSession.m 50.68% <0.00%> (-0.13%) ⬇️
...SDK/Crypto/Verification/MXKeyVerificationManager.m 72.36% <0.00%> (+0.21%) ⬆️
MatrixSDK/Crypto/MXCrypto.m 71.95% <0.00%> (+0.49%) ⬆️
...rixSDK/Aggregations/MXAggregatedReactionsUpdater.m 86.39% <0.00%> (+0.64%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93670ea...fb326d8. Read the comment docs.

@pixlwave pixlwave merged commit 339b12c into develop Aug 2, 2022
@pixlwave pixlwave deleted the doug/6481-join-body branch August 2, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/join requests with malformed body
3 participants