Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id_server from creds for interactive auth #1044

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Sep 25, 2019

For HSes that do not require an IS, we can remove id_server from the auth
params.

Fixes element-hq/element-web#10959

For HSes that do not require an IS, we can remove `id_server` from the auth
params.

Fixes element-hq/element-web#10959
@jryans jryans requested a review from a team September 25, 2019 14:01
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

src/interactive-auth.js Show resolved Hide resolved
@jryans jryans merged commit b09621b into develop Sep 25, 2019
@t3chguy t3chguy deleted the jryans/rm-id-server-creds branch May 10, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove id_server from email threepid_creds
2 participants