Remove unstable support for m.room_key.withheld
#2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer send or receive the unstable type.
robintown
approved these changes
Jul 11, 2022
|
(leaving open so this doesn't go into the RC, giving the crypto team a chance to at least protest my decisions here 😇 ) |
|
Android Matching PR element-hq/element-android#6520 For now will support receiving both unstable and stable, but only send stable. will clear after more clients have updated |
|
release scheduling appears to work out on this - discussed oob. |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Aug 22, 2022
* Remove unstable support for `m.room_key.withheld` ([\matrix-org#2512](matrix-org#2512)). Fixes matrix-org#2233. * Sliding sync: add missing filters from latest MSC ([\matrix-org#2555](matrix-org#2555)). * Use stable prefixes for MSC3827 ([\matrix-org#2537](matrix-org#2537)). * Add support for MSC3575: Sliding Sync ([\matrix-org#2242](matrix-org#2242)). * Correct the units in TURN servers expiry documentation ([\matrix-org#2520](matrix-org#2520)). * Re-insert room IDs when decrypting bundled redaction events returned by `/sync` ([\matrix-org#2531](matrix-org#2531)). Contributed by @duxovni.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer send or receive the unstable type.
The MSC was merged to the spec about 2 years ago, so we should be more than safe to remove this sort of support. It was formally released in v1.1 of the spec in November of 2021, well beyond the 2 month window the spec requests of implementation for a grace period.
The only implementation I can see which hasn't changed over is Element Android: https://github.com/matrix-org/matrix-android-sdk2/blob/3adfe4d01c8ff5189ada1373015501256e2a2d57/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/events/model/EventType.kt#L90
Given the massive time scale and spec process here, I'm keen to land this without waiting for Android to fix their event type usage. Otherwise, we risk having to put
org.matrix.room_key.withheldinto the spec, which I am absolutely not going to be happy about :)Fixes #2233
Here's what your changelog entry will look like:
🦖 Deprecations
m.room_key.withheld(#2512). Fixes Stop using unstable names for withheld codes #2233.