Feat: Voice activity threshold

[hugohutri]

Adding voice activity detection feature

More information at element-hq/element-call#492

Notes: none

---

This change has no change notes, so will not be included in the changelog.

[dbkr]

I've left more feedback over on the element call PR, but specifically to this PR, remember to check for your editor reformatting files before committing.

[SimonBrandner]

Just a few nitpicks, we're getting really close with this!

One more tiny nit: we tend to write comments with a space after the slashes (i.e. // comment not //comment)

[SimonBrandner]

Sorry, I think I probably wasn't clear - I was suggesting adding AUDIO_DELAY = 0.001; // ms at the top of a file and using it here - would that work?

[DashieTM]

Just a few nitpicks, we're getting really close with this!

One more tiny nit: we tend to write comments with a space after the slashes (i.e. // comment not //comment)

No worries, changed the ones in the tests.
Just so I don't make another new comment, I also put the audio delay on the same spot as the cooldown and treshold.
This number works ofc, just not the node itself :P

[SimonBrandner]

LGTM now! Will also request Dave's review, just to be sure

[DashieTM]

LGTM now! Will also request Dave's review, just to be sure

Awesome!!
One thing though:
we likely need some human feedback on whether or not the settings like the cooldown and the quality are ok.
I will try to personally test this out with friends, but more people would always be nice.
(although I am behind a NAT with my low power server, so this will prob be a pain. Until now I have tested it locally.)

Is the intention to mass test this alongside other features in a hosted version of element-call?

[SimonBrandner]

LGTM now! Will also request Dave's review, just to be sure

Awesome!! One thing though: we likely need some human feedback on whether or not the settings like the cooldown and the quality are ok. I will try to personally test this out with friends, but more people would always be nice. (although I am behind a NAT with my low power server, so this will prob be a pain. Until now I have tested it locally.)

Is the intention to mass test this alongside other features in a hosted version of element-call?

Hmm, I think this would be best to discuss over at element-call with Jake since he's the one on the product team. Sorry, for late response...

[DashieTM]

Hmm, I think this would be best to discuss over at element-call with Jake since he's the one on the product team. Sorry, for late response...

No worries, also got lot's of stuff to do :P

[dbkr]

I was attempting to test this but I couldn't get it to work as it was NPEing on the local call feed:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'setVoiceActivityThreshold')
    at GroupCall.setVoiceActivityThreshold (groupCall.ts:556:35)
    at GroupCallView.tsx:92:15
    at commitHookEffectListMount (react-dom.development.js:23150:26)
    at commitPassiveMountOnFiber (react-dom.development.js:24926:13)
    at commitPassiveMountEffects_complete (react-dom.development.js:24891:9)
    at commitPassiveMountEffects_begin (react-dom.development.js:24878:7)
    at commitPassiveMountEffects (react-dom.development.js:24866:3)
    at flushPassiveEffectsImpl (react-dom.development.js:27039:3)
    at flushPassiveEffects (react-dom.development.js:26984:14)
    at react-dom.development.js:26769:9

Also, more points that are really for design, but I wasn't sure from the UI when I'd be muted/unmuted based on voice activity. It also seems a bit odd that it's in 'advanced' and not 'audio'.

[DashieTM]

I will see what causes the error, that ofc shouldn't happen.
Is there anything specific that causes the error? Or just regular use?

As for why it is in an advanced tab. We were asked to do this: