Include 'browser' in list of adjusted properties in release.sh #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
approved these changes
Feb 14, 2023
andybalaam
added
the
backport staging
andybalaam
deleted the
andybalaam/include-browser-in-release-adjustment
branch
RiotRobot
pushed a commit
that referenced
this pull request
Feb 14, 2023
(cherry picked from commit 5e17626)
andybalaam
added a commit
that referenced
this pull request
Feb 14, 2023
|
@andybalaam could you add some notes for future archaeologists about what this fixed and why it was important? |
@richvdh thank you for the prompt. I have added what I know to the PR description. |
|
Thanks. Any chance you could also translate the summary of #3135 into something that makes sense? 😇 |
|
I've added one sentence to the summary above but I think we've reached the extent of my understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3135 .
This fix affects the code we have that adjusts several fields in package.json to allow us to build normally when we package matrix-js-sdk into an npm package, but build it weirdly into element-web as a single package instead of consuming the npm package.
This special code has always been missing
browser, but the problem was masked until a few weeks ago when we changed the packaging so that this error was exposed instead of being ignored.The consequence was that people building apps on top of matrix-js-sdk saw a build error.
This change is marked as an internal change (Task), so will not be included in the changelog.