Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate device methods in MatrixClient #3357

Merged
merged 1 commit into from
May 15, 2023
Merged

Deprecate device methods in MatrixClient #3357

merged 1 commit into from
May 15, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented May 12, 2023 •
edited by github-actions bot
Loading

#3272 added new methods to CryptoApi for accessing user device lists. Mark the old ones as deprecated.

Here's what your changelog entry will look like:

🦖 Deprecations

  • Deprecate device methods in MatrixClient (#3357).

@richvdh richvdh requested a review from a team as a code owner May 12, 2023 14:02
@richvdh richvdh requested review from dbkr and t3chguy May 12, 2023 14:02
germain-gg
germain-gg approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@richvdh richvdh added this pull request to the merge queue May 15, 2023
Merged via the queue into develop with commit af38021 May 15, 2023
@richvdh richvdh deleted the rav/deprecate_device_methods branch May 15, 2023 10:50
@t3chguy t3chguy added T-Deprecation A pull request that makes something deprecated and removed T-Enhancement labels May 16, 2023
@t3chguy
Copy link
Member

t3chguy commented May 16, 2023

@richvdh can I ask you to use T-Deprecation on such PRs so allchange puts it in the right section of our changelog

@richvdh
Copy link
Member Author

richvdh commented May 16, 2023

ah sorry, forgot that was a thing

@richvdh richvdh mentioned this pull request May 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Deprecation A pull request that makes something deprecated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richvdh @t3chguy @germain-gg