-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MatrixClient.encryptAndSendToDevices for rust crypto and add CryptoApi.encryptToDeviceMessages #4380
Draft
hughns
wants to merge
16
commits into
develop
Choose a base branch
from
hughns/rust-send-to-device
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate Crypto. encryptAndSendToDevices and MatrixClient. encryptAndSendToDevices
hughns
added
T-Enhancement
T-Deprecation
A pull request that makes something deprecated
labels
Sep 2, 2024
hughns
changed the title
Add CryptoApi. encryptToDeviceMessages
Implement MatrixClient.encryptAndSendToDevices for rust crypto and add CryptoApi.encryptToDeviceMessages
Sep 2, 2024
richvdh
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the right general direction to me
hughns
changed the base branch from
develop
to
hughns/matrix-sdk-crypto-wasm-8
September 9, 2024 09:58
Closed
4 tasks
hughns
changed the base branch from
hughns/matrix-sdk-crypto-wasm-8
to
develop
September 18, 2024 08:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3304
Depends on matrix-org/matrix-rust-sdk-crypto-wasm#140 and #4396
Checklist
public
/exported
symbols have accurate TSDoc documentation.