Fix for "otherMember.getAvatarUrl is not a function" #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the user fallback, the complete thing to do here would also be to fallback to fetching the user profile for a hero if the user and member are not available, but then the whole things becomes async. I guess this will be fine for now. |
dbkr
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/matrix-org/riot-web-rageshakes/issues/962
was hitting
Unhandled rejection TypeError: otherMember.getAvatarUrl is not a functionbecause in case of summary heroes it is returning a userid and not a member.Also adds another fallback route for getting the avatar by looking up the user.