Device manager - put client/browser device metadata in correct section (

#9447)
matrix-org · Oct 18, 2022 · b04991a · b04991a
1 parent 67dbb36
commit b04991a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/src/components/views/settings/devices/DeviceDetails.tsx b/src/components/views/settings/devices/DeviceDetails.tsx
@@ -62,7 +62,6 @@ const DeviceDetails: React.FC<Props> = ({
             id: 'session',
             values: [
                 { label: _t('Session ID'), value: device.device_id },
-                { label: _t('Client'), value: device.client },
                 {
                     label: _t('Last activity'),
                     value: device.last_seen_ts && formatDate(new Date(device.last_seen_ts)),
@@ -84,6 +83,7 @@ const DeviceDetails: React.FC<Props> = ({
             values: [
                 { label: _t('Model'), value: device.deviceModel },
                 { label: _t('Operating system'), value: device.deviceOperatingSystem },
+                { label: _t('Browser'), value: device.client },
                 { label: _t('IP address'), value: device.last_seen_ip },
             ],
         },

diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json
@@ -1742,14 +1742,14 @@
     "Rename session": "Rename session",
     "Please be aware that session names are also visible to people you communicate with": "Please be aware that session names are also visible to people you communicate with",
     "Session ID": "Session ID",
-    "Client": "Client",
     "Last activity": "Last activity",
     "Application": "Application",
     "Version": "Version",
     "URL": "URL",
     "Device": "Device",
     "Model": "Model",
     "Operating system": "Operating system",
+    "Browser": "Browser",
     "IP address": "IP address",
     "Session details": "Session details",
     "Toggle push notifications on this session.": "Toggle push notifications on this session.",

diff --git a/test/components/views/settings/devices/__snapshots__/DeviceDetails-test.tsx.snap b/test/components/views/settings/devices/__snapshots__/DeviceDetails-test.tsx.snap
@@ -181,18 +181,6 @@ exports[`<DeviceDetails /> renders device with metadata 1`] = `
               my-device
             </td>
           </tr>
-          <tr>
-            <td
-              class="mxDeviceDetails_metadataLabel"
-            >
-              Client
-            </td>
-            <td
-              class="mxDeviceDetails_metadataValue"
-            >
-              Firefox 100
-            </td>
-          </tr>
           <tr>
             <td
               class="mxDeviceDetails_metadataLabel"
@@ -269,6 +257,18 @@ exports[`<DeviceDetails /> renders device with metadata 1`] = `
               Windows 95
             </td>
           </tr>
+          <tr>
+            <td
+              class="mxDeviceDetails_metadataLabel"
+            >
+              Browser
+            </td>
+            <td
+              class="mxDeviceDetails_metadataValue"
+            >
+              Firefox 100
+            </td>
+          </tr>
           <tr>
             <td
               class="mxDeviceDetails_metadataLabel"