This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix long display name overflowing reply tile on IRC layout #10273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
|
Hello @luixxiul thank you for your contribution. Does this relate to any issue? If yes, can you link it? Can you always add screenshots from before and after for visual changes? |
|
Thanks for the heads-up. I'm going to do them later, before making this PR ready for review. |
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
luixxiul
changed the title
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…tedProfile Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
luixxiul
commented
Mar 4, 2023
| width: unset; | ||
| background: transparent; | ||
| order: unset; | ||
| flex-shrink: unset; /* Unset flex-shrink to prevent long display name blowout */ |
There was a problem hiding this comment.
This resets flex-shrink: 0; specified above.
3 tasks
|
Removed the branch by mistake. Recreating a PR. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that a long display name overflows
ReplyTileon IRC layout.It also adds a stress test to check that long strings do not overflow and are displayed with ellipsis where needed on each layout.
Fixes element-hq/element-web#24738
type: defect
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes