This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Apply strictNullChecks to src/components/views/settings
#10724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryarchibald
added
the
T-Task
3 tasks
added 6 commits
April 28, 2023 16:58
added 4 commits
May 1, 2023 14:30
This reverts commit c5df9ba.
…rry/25217/snc-views-settings
florianduros
approved these changes
May 3, 2023
| @@ -316,7 +319,7 @@ export default class Notifications extends React.PureComponent<IProps, IState> { | |||
| // noinspection JSUnfilteredForInLoop | |||
| const kind = k as PushRuleKind; | |||
|
|
|||
| for (const r of ruleSets.global[kind]) { | |||
| for (const r of ruleSets.global[kind]!) { | |||
There was a problem hiding this comment.
Maybe add an explanation why we are sure that ruleSets.global[kind] is defined
| @@ -344,7 +347,7 @@ export default class Notifications extends React.PureComponent<IProps, IState> { | |||
| preparedNewState.vectorPushRules[category] = []; | |||
| for (const rule of defaultRules[category]) { | |||
| const definition: VectorPushRuleDefinition = VectorPushRulesDefinitions[rule.rule_id]; | |||
| const vectorState = definition.ruleToVectorState(rule); | |||
| const vectorState = definition.ruleToVectorState(rule)!; | |||
There was a problem hiding this comment.
Maybe add an explanation why we are sure that vectorState is defined
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#25217
Fixes element-hq/element-web#25017
For element-hq/element-web#21967
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.