Conform more of the codebase to strictNullChecks + noImplicitAny #11179
Conversation
t3chguy
added
the
T-Task
| if (!lookup || !lookup.mxid) { | ||
| if (!lookup || !("mxid" in lookup)) { |
There was a problem hiding this comment.
I'm sure this is valid, but i'm not sure i understand what rule it's conforming to?
There was a problem hiding this comment.
Its because the return type is {} | { mxid: string; ... } so to make TS happy we can't just do !lookup.mxid as {}.mxid is invalid. So we have to use in for narrowing
| This invite to RoomPreviewBar-test-room was sent to test@test.com | ||
| Do you want to join RoomPreviewBar-test-room? |
There was a problem hiding this comment.
Are we expecting this change in the snapshot? It looks like what it prints does not match the test name anymore, could we update it?
There was a problem hiding this comment.
Yes. It does actually match, it was wrong before. The test name is renders invite message when invite email mxid match yet it was the same snapshot as renders email mismatch message when invite email mxid *doesnt* match. When the email matches it should be treated as a normal invite, removing the complexity of email invites.
… t3chguy/types/3jul23
Requires matrix-org/matrix-js-sdk#3537
This change is marked as an internal change (Task), so will not be included in the changelog.