This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 834
Accessibility: Add Landmark navigation #12190
Merged
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
98dd07c
Override aria-label for whole tile
akirk 6e6696e
Message navigation
akirk b777dbd
Change hotkeys to use cmd/ctrl
akirk 3bb1bb4
Add landmark navigation
akirk 45cd0da
No cmd in Electron
akirk fd93d03
Fallback when no room is selected
akirk a954941
Review fixes
akirk 1eac6ff
Handle invisible events better
akirk 36048c1
Fix lint errors
akirk 4c2c31f
Lint fixes, remove stray code from other PR
akirk 645dc4c
Remove message navigation code
akirk f55ba53
Remove more stray code
akirk 9bdc225
lint fixes
akirk e34baa5
fix room list landmark
akirk 5ebd292
lint fixes
akirk d9d10d2
Remove copied function
akirk af40c89
update comment
akirk aee0c5f
lint
akirk 87ce6d2
Update keyboard user settings snapshot
akirk 87492e3
Merge branch 'develop' into add-landmark-navigation
MidhunSureshR e3ebda6
Fix lint
MidhunSureshR 7fba563
Move code to a single file
MidhunSureshR f3b7f12
Merge branch 'develop' into add-landmark-navigation
MidhunSureshR 7eb4dc6
Add jest test
MidhunSureshR 9608b75
Merge branch 'develop' into add-landmark-navigation
MidhunSureshR d043ae9
Use a circular array for storing the order of landmarks
MidhunSureshR e38849a
Fix test
MidhunSureshR 7edb9d4
Rename test
MidhunSureshR b493ac2
Change implementation
MidhunSureshR 1396862
Add playwright test
MidhunSureshR 477f58e
Add more tests
MidhunSureshR 6c8e191
Fix comments and name
MidhunSureshR b2ce73b
Replacee method with Array.at
MidhunSureshR ea4fea8
Make changes from review
MidhunSureshR 0961cae
Fix case; landmarkToDOMElementMap -> landmarkToDomElementMap
MidhunSureshR 114cc77
Add stricter check
MidhunSureshR 1d8ab2a
Add type to map
MidhunSureshR 9f29735
Pass focusVisible option to focus call
MidhunSureshR d1085b7
Move type to global.d.ts
MidhunSureshR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this type in
global.d.ts
instead to avoid needing to type cast and to get the benefit in all files? As an overload for theHTMLElement::focus
methodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, d1085b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might need to be optional
focusVisible?: boolean
but CI will show