This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Disable playwright tests for legacy crypto #12662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
added
the
T-Task
We only ever run under the rust stack now, so these conditions are redundant.
We don't need this any more
richvdh
force-pushed
the
rav/disable_legacy_crypto_playwright
branch
from
6f73a54
to
6cb70ff
Compare
t3chguy
approved these changes
Jun 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #12630, the "legacy crypto" playwright test run will actually run on Rust crypto, so this is worse than useless.
Reviewable commit-by-commit.