Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix reply message truncation on 2 lines #12929

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Fix reply message truncation on 2 lines #12929

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d18e5b
Fix reply message truncation on 2 lines
florianduros Aug 26, 2024
a79a2e0
Merge branch 'refs/heads/develop' into florianduros/fix/reply-line
florianduros Aug 27, 2024
9996eef
Add e2e tests for reply
florianduros Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion res/css/views/elements/_ReplyChain.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ limitations under the License.
white-space: nowrap; /* Enforce 'In reply to' to be a single line */
color: $secondary-content;
transition: color ease 0.15s;
font-weight: var(--cpd-font-weight-normal);
Copy link
Contributor Author

@florianduros florianduros Aug 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but the css var was incorrect.

font-weight: var(--cpd-font-weight-regular);
text-decoration: inherit;

&:hover {
Expand Down
5 changes: 3 additions & 2 deletions res/css/views/rooms/_EventTile.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ $left-gutter: 64px;

.mx_ReplyChain--expanded {
.mx_EventTile_body {
display: block;
/* !important needed to override .mx_ReplyTile .mx_EventTile_content .mx_EventTile_body */
display: block !important;
overflow-y: scroll;
}

Expand Down Expand Up @@ -899,7 +900,7 @@ $left-gutter: 64px;
object-fit: contain;
object-position: left top;

/* Override the default colors of the 'github-markdown-css' library
/* Override the default colors of the 'github-markdown-css' library
(#fff for light theme, #000 for dark theme) to match the inherited theme */
background-color: inherit !important;
}
Expand Down
5 changes: 5 additions & 0 deletions res/css/views/rooms/_ReplyTile.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ limitations under the License.
font-size: $font-14px !important; /* Override the big emoji override */
}

// in order to keep the message on two lines, we need to make the body inline
.mx_EventTile_body {
display: inline;
}

// Hide line numbers and edited indicator
.mx_EventTile_lineNumbers,
.mx_EventTile_edited {
Expand Down
Loading