Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix JS-SDK failing import #12939

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fix JS-SDK failing import #12939

merged 1 commit into from
Aug 30, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Aug 30, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Due to matrix-org/matrix-js-sdk#4377
Add allowImportingTsExtensions to our tsconfigs

@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 30, 2024
@florianduros florianduros force-pushed the florianduros/fix/ci-ts-extension branch from 189f5b3 to d8baf8a Compare August 30, 2024 08:47
@florianduros florianduros changed the title Copy babel config of the js-sdk config Fix JS-SDK failing import Aug 30, 2024
@florianduros florianduros force-pushed the florianduros/fix/ci-ts-extension branch from d8baf8a to a7e445c Compare August 30, 2024 08:48
@florianduros florianduros mentioned this pull request Aug 30, 2024
Merged
4 tasks
@florianduros florianduros force-pushed the florianduros/fix/ci-ts-extension branch from a7e445c to a0646d8 Compare August 30, 2024 13:38
@florianduros florianduros marked this pull request as ready for review August 30, 2024 13:52
@florianduros florianduros requested a review from a team as a code owner August 30, 2024 13:52
@florianduros florianduros added this pull request to the merge queue Aug 30, 2024
Merged via the queue into develop with commit 2a450c0 Aug 30, 2024
34 checks passed
@florianduros florianduros deleted the florianduros/fix/ci-ts-extension branch August 30, 2024 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @richvdh