This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make ActiveWidgetStore clear persistent widgets #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActiveWidgetStore is now reponsible for removing the current persistent widget from the store if it's been removed from whatever room it was in. As per comment, this leaves us with the store updating itself in this case but in all other cases, views call setters on the store to update its state. We should make it so the store keeps itself up to date and views aren't responsible for keeping the store up to date. The store now emits events so it can notify PersistentApp when it changes. Fixes element-hq/element-web#7076
bwindels
suggested changes
Jul 24, 2018
| } | ||
| } | ||
|
|
||
| _destroyPersistentWidget() { |
There was a problem hiding this comment.
seems duplicated with ActiveWidgetStore::onRoomStateEvents. Have a single public method in ActiveWidgetStore that does this?
There was a problem hiding this comment.
Yeah, was on the fence about whether to do this now or leave it until moving more stuff to the store, but probably better to do it now.
src/Lifecycle.js
Outdated
| @@ -488,6 +490,7 @@ export function stopMatrixClient() { | |||
| Notifier.stop(); | |||
| UserActivity.stop(); | |||
| Presence.stop(); | |||
| ActiveWidgetStore.start(); | |||
There was a problem hiding this comment.
this should probably be stop()
bwindels
approved these changes
Jul 24, 2018
|
@dbkr Test failed before on: Probably still do |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveWidgetStore is now reponsible for removing the current
persistent widget from the store if it's been removed from whatever
room it was in. As per comment, this leaves us with the store updating
itself in this case but in all other cases, views call setters on the
store to update its state. We should make it so the store keeps itself
up to date and views aren't responsible for keeping the store up to date.
The store now emits events so it can notify PersistentApp when it changes.
Fixes element-hq/element-web#7076
Based on #2081