This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Redesign: room directory makeover #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
changed the title
turt2live
approved these changes
Jan 29, 2019
| } | ||
|
|
||
| .mx_RoomDirectory_searchbox { | ||
| display: table-cell; | ||
| vertical-align: middle; | ||
| flex: 1 !important; |
There was a problem hiding this comment.
do more specific styles help at all in this case? Something like .mx_RoomDirectory_dialogWrapper .mx_RoomDirectory_searchBox ?
There was a problem hiding this comment.
Tried that, but the rule it's trying to override is very very specific (see _dharma.scss:260). The whole mx_textinput/ global input styles need to be better scoped anyways, so rather postpone this till then.
There was a problem hiding this comment.
:(
+1 to postponing. It's not a major problem, just a thing we should avoid if possible
src/i18n/strings/en_EN.json
Outdated
| @@ -1497,5 +1497,6 @@ | |||
| "If you didn't remove the recovery method, an attacker may be trying to access your account. Change your account password and set a new recovery method immediately in Settings.": "If you didn't remove the recovery method, an attacker may be trying to access your account. Change your account password and set a new recovery method immediately in Settings.", | |||
| "Failed to set direct chat tag": "Failed to set direct chat tag", | |||
| "Failed to remove tag %(tagName)s from room": "Failed to remove tag %(tagName)s from room", | |||
| "Failed to add tag %(tagName)s to room": "Failed to add tag %(tagName)s to room" | |||
| "Failed to add tag %(tagName)s to room": "Failed to add tag %(tagName)s to room", | |||
| "Join": "Join" | |||
There was a problem hiding this comment.
npm run i18n please to maintain ordering
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element-hq/element-web#7607
A bit hacky in places, sorry.