This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Rework room directory so that new room is always available #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reorganises the room directory so that the new room buttons is always available no matter what state the overall directory is in. Part of element-hq/element-web#9046
This changes errors that may occur when loading the room directory so that the message appears inline with the overall directory UI instead of in a new modal. This is important so that the new room button remains on screen even if the directory is down. Fixes element-hq/element-web#9046
dbkr
approved these changes
Mar 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves room directory code paths so that new room is always possible to click inside the room directory.
Fixes element-hq/element-web#9046