Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Consolidate Themes into ThemeController. Remove hardcoded themes in view #3304

Merged
merged 2 commits into from
Aug 12, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 11, 2019

Fixes part of element-hq/element-web#10486

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team August 11, 2019 02:44
@turt2live
Copy link
Member

@t3chguy looks like you need to run the i18n script

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just lodging a concern for future readers. I would not solve the problem here.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from turt2live August 12, 2019 13:24
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still fine, although in the distant future I think a getOptions thing is the best route.

@t3chguy t3chguy merged commit bb23374 into develop Aug 12, 2019
@t3chguy t3chguy deleted the t3chguy/un-hardcode-themes-in-settings branch April 27, 2020 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants