Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Wire up the invite targets dialog to a real composer and show selections #3815

Merged
merged 8 commits into from
Jan 9, 2020

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jan 7, 2020

For element-hq/element-web#11199

Note: this looks a bit funny because it also boostraps the dialog for 3PID/email support, but that was dropped from this PR due to diff size/scope. Should be followed shortly with a PR that makes it work.

image

@turt2live turt2live marked this pull request as ready for review January 7, 2020 19:29
@turt2live turt2live requested a review from a team January 7, 2020 19:29
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! 😁 Broadly it looks good, but I think the SVGs need to be re-exported first.

@@ -0,0 +1,37 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am 95% confident this SVG can be much simpler (likely the filter and ~5 transforms can go away) if exported in a different way. @nadonomy should be able to make it happen.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the SVG supplied by Nad, though shoved through inkscape to fix some viewport problems.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and by shoved through inkscape I mean in a later PR it is shoved through inkscape.

Copy link
Collaborator

@jryans jryans Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried mentioning the filter and transform layers to him? In the past, I believe he's been able to resolve it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I generally assume that the SVG is production ready from wherever I get it from. Will ask.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave the email avatar for #3819 just so I don't have merge conflicts across my own PRs.

res/img/icon-pill-remove.svg Outdated Show resolved Hide resolved
src/components/views/dialogs/DMInviteDialog.js Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from jryans January 9, 2020 20:40
@turt2live turt2live merged commit ba73600 into develop Jan 9, 2020
@turt2live turt2live deleted the travis/ftue/user-lists/4-composer branch January 9, 2020 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants