Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Prioritise and reduce the amount of events decrypted on application startup #5980

Merged
merged 11 commits into from
May 12, 2021

Conversation

germain-gg
Copy link
Contributor

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looking reasonable to me so far! 😄

src/components/structures/TimelinePanel.js Show resolved Hide resolved
src/stores/BreadcrumbsStore.ts Outdated Show resolved Hide resolved
src/stores/BreadcrumbsStore.ts Outdated Show resolved Hide resolved
@jryans
Copy link
Collaborator

jryans commented May 7, 2021

As discussed, I expect we'll need to tweak the event indexer as well, but anyway you're already looking into that. 😄

@germain-gg germain-gg changed the title Lazily decrypt events on room view Prioritise and reduce the amount of events decrypted on application startup May 10, 2021
@germain-gg germain-gg marked this pull request as ready for review May 10, 2021 17:18
@germain-gg germain-gg requested a review from a team May 10, 2021 17:18
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am mostly being a nitpick linter here: the code looks fine, just a bunch of small things about the style.

src/components/structures/TimelinePanel.js Outdated Show resolved Hide resolved
src/indexing/EventIndex.js Show resolved Hide resolved
src/indexing/EventIndex.js Show resolved Hide resolved
src/stores/BreadcrumbsStore.ts Outdated Show resolved Hide resolved
src/stores/BreadcrumbsStore.ts Show resolved Hide resolved
src/stores/BreadcrumbsStore.ts Outdated Show resolved Hide resolved
src/stores/BreadcrumbsStore.ts Outdated Show resolved Hide resolved
src/stores/BreadcrumbsStore.ts Outdated Show resolved Hide resolved
src/components/structures/MatrixChat.tsx Show resolved Hide resolved
@germain-gg germain-gg requested a review from turt2live May 11, 2021 09:19
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your patience with the human linter :)

@germain-gg germain-gg merged commit 91133ed into develop May 12, 2021
@germain-gg germain-gg deleted the gsouquet/cache-decrypt branch May 12, 2021 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants