Better feedback in invite dialog #625
Conversation
Show feedback if you enter a valid but unknown email address or mxid Fixes element-hq/element-web#2933
|
Actually, hold off on reviewing, I want to change the props of AddressSelector again |
Rather than just passing in a list of strings. This paves the way for passing in display names & avatars of looked-up threepids.
|
OK, ready now |
| queryList = this._userList.filter((user) => { | ||
| return this._matches(query, user); | ||
| }).map((user) => { | ||
| return { |
There was a problem hiding this comment.
it'd be helpful to record the structure of the objects in queryList and inviteList somewhere (in getInitialState?)
There was a problem hiding this comment.
Oh, I see you already have that in InviteAddressType. Could you point to it somehow?
| address: addressText, | ||
| isKnown: false, | ||
| }; | ||
| if (addrType == null) { |
| var React = require("react"); | ||
| var sdk = require("../../../index"); | ||
| var classNames = require('classnames'); | ||
| const React = require("react"); |
There was a problem hiding this comment.
if you're going to rewrite these (which I applaud), can you switch to import instead of require?
| const React = require("react"); | ||
| const sdk = require("../../../index"); | ||
| const classNames = require('classnames'); | ||
| const InviteAddressType = require("./AddressTile"); |
There was a problem hiding this comment.
this looks dodge - the default export of AddressTile is the react component, not InviteAddressType.
and rewrite to import while we're at it
|
ok, ptal |
|
hrm, sorry, could we specify the structure of the objects in LGTM otherwise |
Show feedback if you enter a valid but unknown email address
or mxid
Also removes the network indicator, which in practice was always an 'R' since there was only one network.
Fixes element-hq/element-web#2933
Fixes element-hq/element-web#2934