Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Don't show a modal on call reject/user hangup #6580

Merged
merged 2 commits into from
Aug 8, 2021
Merged

Don't show a modal on call reject/user hangup #6580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78f53b3
Don't show modal on reject/user hangup
SimonBrandner Aug 7, 2021
2d5dc6d
Break instead of return
SimonBrandner Aug 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/CallHandler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,13 +509,17 @@ export default class CallHandler extends EventEmitter {
this.removeCallForRoom(mappedRoomId);
if (oldState === CallState.InviteSent && call.hangupParty === CallParty.Remote) {
this.play(AudioID.Busy);

// Don't show a modal when we got rejected/the call was hung up
if (!hangupReason || [CallErrorCode.UserHangup, "user hangup"].includes(hangupReason)) break;

let title;
let description;
// TODO: We should either do away with these or figure out a copy for each code (expect user_hangup...)
if (call.hangupReason === CallErrorCode.UserBusy) {
title = _t("User Busy");
description = _t("The user you called is busy.");
} else if (hangupReason && ![CallErrorCode.UserHangup, "user hangup"].includes(hangupReason)) {
} else {
title = _t("Call Failed");
description = _t("The call could not be established");
}
Expand Down