This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Test to see how fuse feels #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2017 09:03
- Use avatar initial instead of "R" or "?" - Use Fuse.js to do case-insensitive fuzzy search. This allows for better sorting of results as well as search based on weighted keys (so userId has a high weight when the input starts with "@"). - Added debounce of 200ms to prevent analysis on every key stroke. Fuse seems to degrade performance vs. simple, non-fuzzy, unsorted matching, but the debounce should prevent too much computation. - Move the selection to the top when the query is changed. There's no point in staying mid-way through the items at that point.
dbkr
reviewed
Mar 2, 2017
| @@ -85,6 +86,21 @@ module.exports = React.createClass({ | |||
| // Set the cursor at the end of the text input | |||
| this.refs.textinput.value = this.props.value; | |||
| } | |||
| // Create a Fuse instance for fuzzy searching this._userList | |||
| if (!this._fuse) { | |||
There was a problem hiding this comment.
Why would there ever be a _fuse at mount time?
There was a problem hiding this comment.
If the component gets unmounted and then mounted again(?)
This was referenced Mar 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ara4n and I discussed that it would be a good idea to see how fuse feels on /develop.
This splits #724
and fixes element-hq/element-web#2934