Add a dialog showing all reactions to a message #8051
Conversation
chillmastonmuutos
force-pushed
the
chillmastonmuutos/reactionsdialog
branch
2 times, most recently
from
72d0c08
to
ede7db8
Compare
There was a problem hiding this comment.
Thank you for your contribution, in order to move this pull request forward it will need to go through design review. I've added the design team to the list of reviewers, alternatively you can join the Element Design room on Matrix.
Before I go through a more in-depth code review, I believe this would require some tests
src/i18n/strings/fi.json
Outdated
| "Removes user with given id from this room": "Poistaa tunnuksen mukaisen käyttäjän tästä huoneesta", | ||
| "All": "Kaikki" |
There was a problem hiding this comment.
| "Removes user with given id from this room": "Poistaa tunnuksen mukaisen käyttäjän tästä huoneesta", | |
| "All": "Kaikki" | |
| "Removes user with given id from this room": "Poistaa tunnuksen mukaisen käyttäjän tästä huoneesta" |
There was a problem hiding this comment.
Thanks for the input! I can add some tests if you are happy with how the feature works at the moment.
chillmastonmuutos
force-pushed
the
chillmastonmuutos/reactionsdialog
branch
from
ede7db8
to
274c686
Compare
chillmastonmuutos
force-pushed
the
chillmastonmuutos/reactionsdialog
branch
2 times, most recently
from
855d144
to
b0bfbaf
Compare
|
Tests added |
turt2live
added
the
T-Enhancement
|
@chillmastonmuutos when you get a chance, can you update this PR to latest develop for us? |
chillmastonmuutos
force-pushed
the
chillmastonmuutos/reactionsdialog
branch
from
b0bfbaf
to
b365f61
Compare
turt2live
added
the
X-Blocked
|
Hi @chillmastonmuutos - our legal department says while they have received your DCO signoff request, they do not have it marked completed. Until that is completed we won't be able to accept this change, sorry. If you have questions, please forward them to the legal team using the same address you sent the DCO request to. |
|
Can this be resurrected somehow? |
|
@hanthor needs a designer to take it on |
|
Thanks for your contribution. I'm going to close this for now as the changes requested haven't been made. If you're interested in continuing to work on this please let us know and we can reopen the pull request. Thanks! |
|
Please reopen this, as it's still not resolved and strongly needed! |
This PR partly implements the features described here: element-hq/element-web#9723
What is NOT implemented as in the above issue:
Here's a few screenshots:
NOTE! I could not do the sign-off part for this PR, because I do not wish to associate my real name with this GitHub account. I've sent an email to dco@matrix.org regarding anonymous contributions, but so far I've recieved no reply. I'm opening this PR in order to avoid my work going to waste.
Here's what your changelog entry will look like:
✨ Features