Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Support custom emoji in editor and completions. #8087

Closed

Conversation

AndrewRyanChama
Copy link

@AndrewRyanChama AndrewRyanChama commented Mar 19, 2022

This change implements custom inline emojis as specified in matrix-org/matrix-spec-proposals#2545 in the editor and autocompletion suggestions. This does not implement a UI for configuring room image sets, but element users may be in rooms with image sets that were set up in other clients such as Fluffy Chat.

Screen Shot 2022-03-19 at 9 04 00 AM

Screen Shot 2022-03-19 at 9 03 48 AM

The emoji picker will be updated in a separate pr.

Signed-off-by: Andrew Ryan andrewryanchama@clover.club


Here's what your changelog entry will look like:

✨ Features

@AndrewRyanChama AndrewRyanChama requested a review from a team as a code owner March 19, 2022 16:52
@robintown robintown added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 19, 2022
@robintown robintown requested a review from a team March 19, 2022 18:49
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearing code review as there's a chance that the code changes after product/design have a look

@AndrewRyanChama
Copy link
Author

@turt2live what would the next steps be fore a product or design review? Should I submit a request somehwere?

@robintown
Copy link
Member

This PR is in the product review queue, but the product team will likely want to scope out an approach to custom emoji as a whole before they would consider this change, so be prepared to wait.

@MadLittleMods MadLittleMods added the Z-Community-PR Issue is solved by a community member's PR label Jun 1, 2022
@karlabbott
Copy link

From a product perspective, I'm generally in favor of us moving forward with this PR. There is actually a real business use case where the employees of enterprise customers do like to take photos of their coworkers and turn them into emoji memes and use them in this manner.

The only thing that I would caution here is that we need to use this PR to push for the finishing of the work on MSC2545. I'd hate to see us implement this feature only to have it not make spec within a reasonable amount of time after implementation.

Karl Abbott
Product Manager, Element

@turt2live
Copy link
Member

fwiw, from the spec side there are far greater concerns than this PR could ever cause 😅 We'll be taking a look at it from the SCT side to de-risk it (custom emoji is currently slated as the next big client feature after threads).

@JiffyCat
Copy link

@AndrewRyanChama is this PR still active? We want to consolidate the amount of competing PRs in order for the feature to move forward. Product is blocking #9240 since they have to review all competing PRs that are open. If not, please close this PR so #9240 can go forward.

@nmscode
Copy link

nmscode commented Jul 31, 2023

@JiffyCat I have contacted the owner of this PR (@AndrewRyanChama). He has said he is not going to work on this anymore. Specifically:

I don't have any interest in contributing to element anymore at all, and that includes doing housekeeping tasks such as closing or updating old prs
you can quote me on that

This PR can be assumed closed.

@andybalaam
Copy link
Contributor

Closing as per above.

@andybalaam andybalaam closed this Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants