This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Lazy load thread list timeline set #8120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Mar 22, 2022
Codecov Report
@@ Coverage Diff @@
## develop #8120 +/- ##
==========================================
Coverage ? 27.23%
==========================================
Files ? 874
Lines ? 52255
Branches ? 13241
==========================================
Hits ? 14230
Misses ? 38025
Partials ? 0
|
t3chguy
reviewed
Mar 22, 2022
Comment on lines
170
to
176
| useEffect(() => { | ||
| setRoom(mxClient.getRoom(roomId)); | ||
| const room = mxClient.getRoom(roomId); | ||
| room.createThreadsTimelineSets().then(() => { | ||
| setRoom(room); | ||
| setFilterOption(ThreadFilterType.All); | ||
| }); | ||
| }, [mxClient, roomId]); |
There was a problem hiding this comment.
this might be cleaner using useAsyncMemo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#2254
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.Preview: https://pr8120--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.