Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix per-room RightPanel should not remember Notifications card #8273

Closed
wants to merge 2 commits into from

Conversation

ShivraniAJ
Copy link
Contributor

@ShivraniAJ ShivraniAJ commented Apr 9, 2022

Fix: element-hq/element-web#21529
Now when we are switching the room the right panel is not showing.


Here's what your changelog entry will look like:

🐛 Bug Fixes

Preview: https://pr8273--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@ShivraniAJ ShivraniAJ requested a review from a team as a code owner April 9, 2022 21:01
@t3chguy t3chguy added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Apr 11, 2022
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to do the opposite of what it claims to do.

It looks to set the history to the notifications panel on every room change. The tests passing confirm this is not intended behaviour.

@t3chguy
Copy link
Member

t3chguy commented Apr 11, 2022

@ShivraniAJ
Copy link
Contributor Author

This PR seems to do the opposite of what it claims to do.

It looks to set the history to the notifications panel on every room change. The tests passing confirm this is not intended behaviour.

I am trying to fix it, I will do the required changes.

@andybalaam
Copy link
Contributor

@ShivraniAJ are you still working on this?

@ShivraniAJ
Copy link
Contributor Author

@ShivraniAJ are you still working on this?
yes I am still working on this

@ShivraniAJ
Copy link
Contributor Author

I have tried to fix this issue, but I could not find a way to fix it, I am no more working on it.

@andybalaam
Copy link
Contributor

Thank you for your work @ShivraniAJ ! Do ask questions in #element-dev:matrix.org if you need help understanding some code.

@andybalaam andybalaam closed this May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

per-room RightPanel should not remember Notifications card, as it's global
3 participants