Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Display emotes like normal messages #8420

Closed
wants to merge 5 commits into from

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Apr 26, 2022

Default layout before

Screenshot 2022-04-26 at 20 46 26

Default layout after

Screenshot 2022-04-26 at 20 45 54

Bubbles layout before

Screenshot 2022-04-27 at 08 06 04

Bubbles layout after

Screenshot 2022-04-27 at 08 04 31

IRC layout before

Screenshot 2022-04-27 at 08 06 58

IRC layout after

Screenshot 2022-04-27 at 08 09 09

Advantages

  • Time is visible (default layout)
  • User name gives visual hint that it is clickable (default & IRC layout)
  • Reading flow not broken because style is consistent with normal messages (all layouts)

Disadvantages

  • Slightly more vertical space needed (default & bubble layout)

Fixes: element-hq/element-web#2284


Here's what your changelog entry will look like:

🐛 Bug Fixes

Preview: https://pr8420--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Fixes: #element-hq/element-web#2284
Signed-off-by: Johannes Marbach <johannesm@element.io>
@Johennes Johennes requested a review from a team as a code owner April 26, 2022 18:58
@Johennes Johennes marked this pull request as draft April 26, 2022 18:58
@Johennes
Copy link
Contributor Author

Should be enough for design review. I won't bother with fixing the tests before.

@Johennes Johennes marked this pull request as ready for review April 26, 2022 19:16
@robintown
Copy link
Member

This could use screenshots of bubble layout and IRC layout as well

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearing code review while design/product weigh the feature

@turt2live turt2live requested review from a team April 26, 2022 20:15
@Johennes Johennes changed the title Display emotes on two lines like normal messages Display emotes like normal messages Apr 27, 2022
@Johennes
Copy link
Contributor Author

This could use screenshots of bubble layout and IRC layout as well

Good call @robintown. I missed that the layout differs significantly in these modes. 🤦‍♂️

Added screenshots above.

@MadLittleMods MadLittleMods added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems and removed T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels May 11, 2022
@kittykat
Copy link
Contributor

Hi Johennes, thank you for submitting a PR.

From a product pov, we don't want to show emotes like normal messages because they are supposed to indicate an action rather than something that a person says so they should be formatted differently. I'm going to close this PR for this reason, but if you would like to offer a fix for the timestamp issue, that would be appreciated. The best way to do that may be to add padding under the profile pic in the timeline.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timestamp is hidden by the avatars on emotes
5 participants