Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add support for JSX in stuff we import in Cypress test code #8738

Merged
merged 6 commits into from
Jun 30, 2022

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jun 1, 2022

Add support for JSX in stuff we import in Cypress test code

Spawning from:

What have I done so far?

  1. Adding "jsx": "react", to cypress/tsconfig.json -> 9.5k errors
  2. Add --jsx react to the Cypress part of the lint:types package.json script to match the other part of the command there -> 9.5k errors
  3. Add "esModuleInterop": true, to cypress/tsconfig.json -> 189 errors
  4. Add "dom.iterable" to lib in cypress/tsconfig.json matching the root tsconfig.json -> 175 errors
  5. Add import "../src/@types/global"; to cypress/global.d.ts -> 36 errors
  6. Add import "../src/@types/svg"; and import "../src/@types/raw-loader"; to cypress/global.d.ts -> 14 errors
  7. Add "module": "commonjs" to cypress/tsconfig.json -> 0 errors

This change is marked as an internal change (Task), so will not be included in the changelog.

@MadLittleMods MadLittleMods added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 1, 2022
cypress/global.d.ts Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member

t3chguy commented Jun 6, 2022

@MadLittleMods as you should be aware, we need to be load balancing review amongst the team as about 1/3 of all overall reviews are currently done by me which is far from the state we should be in. Given this is a draft, if you want support then I suggest https://matrix.to/#/#element-dev:matrix.org

@t3chguy t3chguy removed their request for review June 6, 2022 20:12
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner marked this pull request as ready for review June 30, 2022 16:05
@SimonBrandner SimonBrandner requested a review from a team as a code owner June 30, 2022 16:05
@SimonBrandner SimonBrandner requested review from duxovni, SimonBrandner, robintown and t3chguy and removed request for SimonBrandner June 30, 2022 16:05
@t3chguy t3chguy changed the title Draft: Add support for JSX in stuff we import in Cypress test code Add support for JSX in stuff we import in Cypress test code Jun 30, 2022
@SimonBrandner SimonBrandner enabled auto-merge (squash) June 30, 2022 16:17
@SimonBrandner SimonBrandner merged commit a587120 into develop Jun 30, 2022
@SimonBrandner SimonBrandner deleted the madlittlemods/cypress-jsx-support branch June 30, 2022 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants