This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 834
Add support for JSX in stuff we import in Cypress test code #8738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Jun 1, 2022
MadLittleMods
commented
Jun 1, 2022
MadLittleMods
commented
Jun 1, 2022
3 tasks
MadLittleMods
commented
Jun 6, 2022
@MadLittleMods as you should be aware, we need to be load balancing review amongst the team as about 1/3 of all overall reviews are currently done by me which is far from the state we should be in. Given this is a draft, if you want support then I suggest https://matrix.to/#/#element-dev:matrix.org |
…press-jsx-support
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
requested review from
duxovni,
SimonBrandner,
robintown and
t3chguy
and removed request for
SimonBrandner
June 30, 2022 16:05
t3chguy
changed the title
Draft: Add support for JSX in stuff we import in Cypress test code
Add support for JSX in stuff we import in Cypress test code
Jun 30, 2022
t3chguy
approved these changes
Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for JSX in stuff we import in Cypress test code
Spawning from:
What have I done so far?
"jsx": "react",
tocypress/tsconfig.json
-> 9.5k errors--jsx react
to the Cypress part of thelint:types
package.json
script to match the other part of the command there -> 9.5k errors"esModuleInterop": true,
tocypress/tsconfig.json
-> 189 errors"dom.iterable"
tolib
incypress/tsconfig.json
matching the roottsconfig.json
-> 175 errorsimport "../src/@types/global";
tocypress/global.d.ts
-> 36 errorsimport "../src/@types/svg";
andimport "../src/@types/raw-loader";
tocypress/global.d.ts
-> 14 errors"module": "commonjs"
tocypress/tsconfig.json
-> 0 errorsThis change is marked as an internal change (Task), so will not be included in the changelog.