Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

MSC2545 support proof-of-concept #8897

Closed
wants to merge 7 commits into from
Closed

Conversation

ckiee
Copy link
Contributor

@ckiee ckiee commented Jun 25, 2022

There are a bazillion things wrong with this code, but I just wanted to put it out there in case anyone else would like to work on it, and just to get feedback about the idea.

Screenshot of element showing the new stickers pop-up

Type: enhancement


Here's what your changelog entry will look like:

✨ Features

TODO

Blockers

  • (maybe?) Ensure the mediaFromMxc stuff would probably break in encrypted rooms.
  • Move some stuff to matrix-js-sdk
  • Check if there's changes after the initial getAccountData.
  • Lab-gate this
  • Rename component from Cookiestickerpicker.
  • Sticker search!

Future

  • Support images as custom emojis too
  • Add a way to add image pack rooms to your user

@ckiee ckiee requested a review from a team as a code owner June 25, 2022 19:59
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jun 25, 2022
@ckiee ckiee marked this pull request as draft June 25, 2022 20:28
@ckiee
Copy link
Contributor Author

ckiee commented Jun 25, 2022

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearing code review while draft

Signed-off-by: ckie <git-525ff67@ckie.dev>
Signed-off-by: ckie <git-525ff67@ckie.dev>
Signed-off-by: ckie <git-525ff67@ckie.dev>
Signed-off-by: ckie <git-525ff67@ckie.dev>
Signed-off-by: ckie <git-525ff67@ckie.dev>
@t3chguy t3chguy mentioned this pull request Jul 26, 2023
3 tasks
@JiffyCat
Copy link

@ckiee is this PR still active? We want to consolidate the amount of competing PRs in order for the feature to move forward. Product is blocking #9240 since they have to review all competing PRs that are open. If not, please close this PR so #9240 can go forward. We support MSC2545 in that PR and can add further features once merged.

@ckiee
Copy link
Contributor Author

ckiee commented Jul 29, 2023

Closing in favor of #9240 since it is clearly superior, though it is worth clearly noting that this PR implements the sticker portion of 2545, which has considerable overlap with the emojo section.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants