This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Read receipts for threads proof of concept (MSC3771) #9130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
added
the
T-Enhancement
justjanne
reviewed
Aug 18, 2022
| } | ||
|
|
||
| const receiptDestination = this.context.threadId | ||
| ? room.getThread(this.context.threadId) |
There was a problem hiding this comment.
room is still optional in props, isn't this going to cause issues here?
|
Just removing me review -- overall this looks good and seems to work well! |
|
There is now a production implementation of this proof of concept |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to matrix-org/matrix-spec-proposals#3771
Fixes element-hq/element-web#22980
To review with matrix-org/matrix-js-sdk#2559
Here's what your changelog entry will look like:
✨ Features