Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

feat(faq): remove keyboard shortcuts button #9342

Merged
merged 6 commits into from
Jul 7, 2023
Merged

feat(faq): remove keyboard shortcuts button #9342

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
91c5f2f
feat(faq): remove keyboard shortcuts button
gefgu Oct 3, 2022
f62b750
Merge branch 'develop' into feat/remove-keyboard-button-in-faq
May 25, 2023
dc18fed
Merge branch 'develop' into feat/remove-keyboard-button-in-faq
May 26, 2023
1a090cc
Merge branch 'develop' into feat/remove-keyboard-button-in-faq
t3chguy Jul 7, 2023
9409fbb
Update HelpUserSettingsTab.tsx
t3chguy Jul 7, 2023
0f54d71
delint
t3chguy Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/components/views/settings/tabs/user/HelpUserSettingsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,8 @@
return `${appVersion}\n${olmVersion}`;
};


private onKeyboardShortcutsClicked = (): void => {

Check failure on line 236 in src/components/views/settings/tabs/user/HelpUserSettingsTab.tsx

View workflow job for this annotation

GitHub Actions / Typescript Syntax Check 

'onKeyboardShortcutsClicked' is declared but its value is never read.
dis.dispatch<OpenToTabPayload>({
action: Action.ViewUserSettings,
initialTabId: UserTab.Keyboard,
Expand All @@ -242,7 +243,7 @@
public render(): React.ReactNode {
const brand = SdkConfig.get().brand;

let faqText = _t(

Check failure on line 246 in src/components/views/settings/tabs/user/HelpUserSettingsTab.tsx

View workflow job for this annotation

GitHub Actions / Typescript Syntax Check 

'faqText' is declared but its value is never read.
"For help with using %(brand)s, click <a>here</a>.",
{
brand,
Expand All @@ -252,7 +253,7 @@
},
);
if (SdkConfig.get("welcome_user_id") && getCurrentLanguage().startsWith("en")) {
faqText = (

Check failure on line 256 in src/components/views/settings/tabs/user/HelpUserSettingsTab.tsx

View workflow job for this annotation

GitHub Actions / ESLint 

'faqText' is assigned a value but never used
<div>
{_t(
"For help with using %(brand)s, click <a>here</a> or start a chat with our " +
Expand Down Expand Up @@ -333,14 +334,10 @@
const { appVersion, olmVersion } = this.getVersionInfo();

return (

<SettingsTab>
<SettingsSection heading={_t("Help & About")}>
{bugReportingSection}
<SettingsSubsection heading={_t("FAQ")} description={faqText}>
<AccessibleButton kind="primary" onClick={this.onKeyboardShortcutsClicked}>
{_t("Keyboard Shortcuts")}
</AccessibleButton>
</SettingsSubsection>
<SettingsSubsection heading={_t("Versions")}>
<SettingsSubsectionText>
<CopyableText getTextToCopy={this.getVersionTextToCopy}>
Expand Down
Loading