This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Comply with noImplicitAny #9940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Task
andybalaam
approved these changes
Jan 20, 2023
clarkf
added a commit
to clarkf/matrix-react-sdk
that referenced
this pull request
Jan 23, 2023
Changes pulled directly from t3chguy's branch. This removes implicit `any` occurrences in `<RoomView />`. See * matrix-org#9940 * element-hq/element-web#21968 Signed-off-by: Clark Fischer <clark.fischer@gmail.com>
3 tasks
clarkf
added a commit
to clarkf/matrix-react-sdk
that referenced
this pull request
Jan 23, 2023
Changes pulled directly from t3chguy's branch. This removes implicit `any` occurrences in `<RoomView />`. See * matrix-org#9940 * element-hq/element-web#21968 Signed-off-by: Clark Fischer <clark.fischer@gmail.com>
clarkf
added a commit
to clarkf/matrix-react-sdk
that referenced
this pull request
Jan 24, 2023
Changes pulled directly from t3chguy's branch. This removes implicit `any` occurrences in `<RoomView />`. See * matrix-org#9940 * element-hq/element-web#21968 Signed-off-by: Clark Fischer <clark.fischer@gmail.com>
3 tasks
|
Blocked on element-hq/element-web#21967 |
t3chguy
added
the
X-Blocked
… t3chguy/fix/21968 # Conflicts: # src/Notifier.ts # src/SlashCommands.tsx # src/components/views/rooms/LinkPreviewWidget.tsx # src/components/views/settings/tabs/room/AdvancedRoomSettingsTab.tsx # src/components/views/settings/tabs/user/GeneralUserSettingsTab.tsx # src/stores/notifications/ThreadNotificationState.ts # src/stores/notifications/ThreadsRoomNotificationState.ts # src/utils/MessageDiffUtils.tsx # test/Notifier-test.ts # test/RoomNotifs-test.ts # test/components/views/dialogs/AccessSecretStorageDialog-test.tsx # test/components/views/messages/MPollBody-test.tsx # test/stores/notifications/RoomNotificationStateStore-test.ts # test/stores/room-list/SlidingRoomListStore-test.ts # test/test-utils/test-utils.ts # test/voice-broadcast/utils/test-utils.ts
t3chguy
removed
the
X-Blocked
andybalaam
approved these changes
Feb 3, 2023
t3chguy
added
the
X-Blocked
|
Blocking until after RC cut for stability |
… t3chguy/fix/21968 # Conflicts: # src/UserActivity.ts # src/accessibility/KeyboardShortcutUtils.ts # src/createRoom.ts # src/editor/parts.ts # src/editor/render.ts # test/components/views/beacon/OwnBeaconStatus-test.tsx # test/components/views/elements/EventListSummary-test.tsx # test/components/views/rooms/wysiwyg_composer/components/WysiwygComposer-test.tsx
t3chguy
removed
the
X-Blocked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#3079
For element-hq/element-web#21968
Doesn't enable noImplicitAny yet due to it needing strictNullChecking to resolve
This change is marked as an internal change (Task), so will not be included in the changelog.